-
Notifications
You must be signed in to change notification settings - Fork 6k
Started handling messages from background isolates for iOS #35174
Started handling messages from background isolates for iOS #35174
Conversation
8d004c5
to
4fa89ff
Compare
7b70a06
to
510bc0a
Compare
1bee788
to
f303fba
Compare
@jason-simmons Can you please have a look at this draft PR? No need to approve it. I just want to make sure we are on a happy path. This PR follows the work outlined in the Isolate Platform Channel design doc and works for iOS Dart->Host messages (notice there is a framework PR if you want to peek at that too). It probably needs a bit more documentation in the source code. I'm still working on a testing plan, your feedback will help inform that. I'm going to have an integration test in the flutter repo for sure. Something you might find interesting is the My plan for this is to get early feedback from you and if everything goes well I'll use this as the template for implementing Dart->Host isolate platform channels across the platforms. I don't have plans on implementing Host->Dart isolate platform channels anytime soon (since it didn't have a clear resolution in the design doc and isn't what most people are asking for). |
f303fba
to
f7d00a5
Compare
I'm concerned that allowing access to the root isolate's I'm not sure what would be the safest way to implement this. The first potential option that comes to mind would be populating the child isolate's Would be interested in getting consensus among the engine team about how best to do this (@chinmaygarde @dnfield) |
6f0dafc
to
9cc8567
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if LGT @jason-simmons
Thanks everyone, I'll get to work cleaning up and putting and the dependent PRs into review today. |
…lutter#35174)" This reverts commit 2be73ba.
This provides all the work for handling platform channels in the Dart->Host direction for iOS. For more details and integration tests see the framework PR.
companion framework pr: flutter/flutter#109005
issue: flutter/flutter#13937
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.